NO-JIRA: Add project documentation to CLAUDE.md #10040
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@zaneb: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Add guidance for Claude Code covering build commands, testing, architecture overview, dependency management, and commit conventions. Assisted-by: Claude Code
Replace hardcoded /tmp path with os.TempDir() to respect TMPDIR environment variable. Add defer statements to clean up temporary files created during vSphere simulator initialization. Assisted-by: Claude Code
Remove vCenter credentials from agent installer validation tests to prevent network connection attempts during unit tests. The tests now validate that credential fields are required when any credential field is specified, in addition to their original validation logic. This change reduces test execution time from 60-180 seconds to under 1 second while maintaining test validity. The tests still verify the same validation errors they were designed to check, plus additional credential validation. Also updated test domains from test.vcenter.com to vcenter.test for consistency with RFC 2606 reserved test domains. Assisted-by: Claude Code
The integration test setup was not passing through the XDG_CACHE_HOME environment variable to the test environment, causing tests to fall back to $HOME/.cache for caching downloaded files. This caused test failures in environments where $HOME/.cache is not writable but XDG_CACHE_HOME points to a writable location. This change ensures that if XDG_CACHE_HOME is set in the test runner's environment, it is passed through to the integration test environment, allowing tests to respect the XDG Base Directory specification. Assisted-by: Claude Code
The testscript framework needs environment variables explicitly passed through to the test environment. This adds passthrough for proxy variables (HTTP_PROXY, HTTPS_PROXY, NO_PROXY and lowercase variants) that may be set by the sandbox or CI environment. Without these, integration tests running behind a proxy would fail with network DNS resolution failures when attempting to download resources. Assisted-by: Claude Code
|
/retest |
|
@zaneb: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| # Skip Terraform build (faster) | ||
| SKIP_TERRAFORM=y hack/build.sh |
There was a problem hiding this comment.
nit: this is no longer true on 4.20+
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
5 participants
Record Claude's experience in running the unit tests and discovering the project structure to CLAUDE.md so that in future it will not have to rediscover any of it from first principles.